Discounted Cumulative Gain #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msluszniak I wanted to get a draft PR up so I can start addressing issues and gaps. Thanks. |
polvalente
reviewed
Oct 11, 2023
polvalente
reviewed
Oct 11, 2023
polvalente
reviewed
Oct 11, 2023
Co-authored-by: Paulo Valente <[email protected]>
Co-authored-by: Paulo Valente <[email protected]>
|
Thank you for the PR. We need to add some changes so all the functions will be |
msluszniak
reviewed
Oct 11, 2023
msluszniak
reviewed
Oct 11, 2023
msluszniak
reviewed
Oct 11, 2023
msluszniak
reviewed
Oct 17, 2023
msluszniak
reviewed
Oct 17, 2023
josevalim
reviewed
Oct 23, 2023
|
We probably need a module name for storing DCG and others. Any suggestions? Ranking? Cumulative? |
Co-authored-by: José Valim <[email protected]>
I like Ranking. |
|
@msluszniak @polvalente are you both happy with Scholar.Metrics.Ranking? |
I am! |
|
@paulsullivanjr so let's namespace those and we should be good to go! :) |
|
Sounds good. Let me know if anything else needs to be updated. Thanks! |
josevalim
approved these changes
Nov 3, 2023
msluszniak
approved these changes
Nov 3, 2023
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Discounted Cumulative Gain metrics logic.